bugs

emencia/django/newsletter/views/admin_views.py

@@ -102,6 +102,7 @@ class ExportContacts(FormView):
         form = self.form_class(request.GET)
         if form.is_valid():
             qs = form.filter()
-            columns = ('first_name', 'email')
-            return ExcelResponse(qs, 'contact_import', columns,'contacts')
+            if qs.count():
+                columns = ('first_name', 'email')
+                return ExcelResponse(qs, 'contact_import', columns,'contacts')
         return HttpResponseRedirect(self.request.META['HTTP_REFERER'])

templates/admin/newsletters/contact_list.html

@@ -133,7 +133,8 @@
             $('legend').on('click', function () {
                 $('.toggled').collapse('toggle');
             });
-            $('#export').on('click', function(){
+            $('#export').on('click', function(event){
+                event.preventDefault();
                 window.location = "{% url 'export_contacts' %}" + get_param;
             })
         })